Workflow approval form: boolean fields have no way to answer #3
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
A deploy workflow run reaches
await-approvaland sends itsaskform to theoperator's inbox. The
endo-releasechart's form declares:The form renders, but the UI offers no control that produces a boolean, so the
field cannot be answered and the run cannot be approved from the interface.
The only way through today is to resolve the form out of band.
Expected: a
M.boolean()field renders as a checkbox, a toggle, or ayes/no pair of buttons, and submitting sends a real boolean.
Actual: no input is offered for the field; the form is unanswerable.
Seen on run
r-6f886ae6d099(chartendo-releasev1, factoryf-f13a89a71394).Charts that ask for a decision are the normal case for the deploy factories, so
this blocks every approval-gated workflow, not just this run.
Fixed and verified — generation 16 (
f6506885).Verified the way that matters: the owner approved run
r-a80dd21cb052throughthe UI, and it applied as generation 17. That run was the first approval on this
host not resolved out of band.
Boolean fields now render as a checkbox and submit a real boolean, in the inbox
and in the new workflow-space approval panel. Recognition is from the field's
pattern (
M.boolean()ismakeTagged('match:kind', 'boolean')), so existingcharts needed no change.
Still string-only, tracked separately:
packages/cli/src/commands/inbox.js.